On Mon, Sep 28, 2009 at 05:35:02PM +0200, Corrado Zoccolo wrote: > On Mon, Sep 28, 2009 at 4:56 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > > On Sun, Sep 27, 2009 at 07:00:08PM +0200, Corrado Zoccolo wrote: > >> Hi Vivek, > >> On Fri, Sep 25, 2009 at 10:26 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > >> > On Fri, Sep 25, 2009 at 04:20:14AM +0200, Ulrich Lukas wrote: > >> >> Vivek Goyal wrote: > >> >> > Notes: > >> >> > - With vanilla CFQ, random writers can overwhelm a random reader. > >> >> > Bring down its throughput and bump up latencies significantly. > >> >> > >> >> > >> >> IIRC, with vanilla CFQ, sequential writing can overwhelm random readers, > >> >> too. > >> >> > >> >> I'm basing this assumption on the observations I made on both OpenSuse > >> >> 11.1 and Ubuntu 9.10 alpha6 which I described in my posting on LKML > >> >> titled: "Poor desktop responsiveness with background I/O-operations" of > >> >> 2009-09-20. > >> >> (Message ID: 4AB59CBB.8090907@xxxxxxxxxxxxxxxxx) > >> >> > >> >> > >> >> Thus, I'm posting this to show that your work is greatly appreciated, > >> >> given the rather disappointig status quo of Linux's fairness when it > >> >> comes to disk IO time. > >> >> > >> >> I hope that your efforts lead to a change in performance of current > >> >> userland applications, the sooner, the better. > >> >> > >> > [Please don't remove people from original CC list. I am putting them back.] > >> > > >> > Hi Ulrich, > >> > > >> > I quicky went through that mail thread and I tried following on my > >> > desktop. > >> > > >> > ########################################## > >> > dd if=/home/vgoyal/4G-file of=/dev/null & > >> > sleep 5 > >> > time firefox > >> > # close firefox once gui pops up. > >> > ########################################## > >> > > >> > It was taking close to 1 minute 30 seconds to launch firefox and dd got > >> > following. > >> > > >> > 4294967296 bytes (4.3 GB) copied, 100.602 s, 42.7 MB/s > >> > > >> > (Results do vary across runs, especially if system is booted fresh. Don't > >> > know why...). > >> > > >> > > >> > Then I tried putting both the applications in separate groups and assign > >> > them weights 200 each. > >> > > >> > ########################################## > >> > dd if=/home/vgoyal/4G-file of=/dev/null & > >> > echo $! > /cgroup/io/test1/tasks > >> > sleep 5 > >> > echo $$ > /cgroup/io/test2/tasks > >> > time firefox > >> > # close firefox once gui pops up. > >> > ########################################## > >> > > >> > Now I firefox pops up in 27 seconds. So it cut down the time by 2/3. > >> > > >> > 4294967296 bytes (4.3 GB) copied, 84.6138 s, 50.8 MB/s > >> > > >> > Notice that throughput of dd also improved. > >> > > >> > I ran the block trace and noticed in many a cases firefox threads > >> > immediately preempted the "dd". Probably because it was a file system > >> > request. So in this case latency will arise from seek time. > >> > > >> > In some other cases, threads had to wait for up to 100ms because dd was > >> > not preempted. In this case latency will arise both from waiting on queue > >> > as well as seek time. > >> > >> I think cfq should already be doing something similar, i.e. giving > >> 100ms slices to firefox, that alternate with dd, unless: > >> * firefox is too seeky (in this case, the idle window will be too small) > >> * firefox has too much think time. > >> > > > Hi Vivek, > > Hi Corrado, > > > > "firefox" is the shell script to setup the environment and launch the > > broser. It seems to be a group of threads. Some of them run in parallel > > and some of these seems to be running one after the other (once previous > > process or threads finished). > > Ok. > > > > >> To rule out the first case, what happens if you run the test with your > >> "fairness for seeky processes" patch? > > > > I applied that patch and it helps a lot. > > > > http://lwn.net/Articles/341032/ > > > > With above patchset applied, and fairness=1, firefox pops up in 27-28 seconds. > > Great. > Can you try the attached patch (on top of 2.6.31)? > It implements the alternative approach we discussed privately in july, > and it addresses the possible latency increase that could happen with > your patch. > > To summarize for everyone, we separate sync sequential queues, sync > seeky queues and async queues in three separate RR strucutres, and > alternate servicing requests between them. > > When servicing seeky queues (the ones that are usually penalized by > cfq, for which no fairness is usually provided), we do not idle > between them, but we do idle for the last queue (the idle can be > exited when any seeky queue has requests). This allows us to allocate > disk time globally for all seeky processes, and to reduce seeky > processes latencies. > Ok, I seem to be doing same thing at group level (In group scheduling patches). I do not idle on individual sync seeky queues but if this is last queue in the group, then I do idle to make sure group does not loose its fair share and exit from idle the moment there is any busy queue in the group. So you seem to be grouping all the sync seeky queues system wide in a single group. So all the sync seeky queues collectively get 100ms in a single round of dispatch? I am wondering what happens if there are lot of such sync seeky queues this 100ms time slice is consumed before all the sync seeky queues got a chance to dispatch. Does that mean that some of the queues can completely skip the one dispatch round? Thanks Vivek > I tested with 'konsole -e exit', while doing a sequential write with > dd, and the start up time reduced from 37s to 7s, on an old laptop > disk. > > Thanks, > Corrado > > > > >> To rule out the first case, what happens if you run the test with your > >> "fairness for seeky processes" patch? > > > > I applied that patch and it helps a lot. > > > > http://lwn.net/Articles/341032/ > > > > With above patchset applied, and fairness=1, firefox pops up in 27-28 > > seconds. > > > > So it looks like if we don't disable idle window for seeky processes on > > hardware supporting command queuing, it helps in this particular case. > > > > Thanks > > Vivek > > -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
