On Sun, Sep 27 2009, Mike Galbraith wrote:
> My dd vs load non-cached binary woes seem to be coming from backmerge.
>
> #if 0 /*MIKEDIDIT sand in gearbox?*/
> /*
> * See if our hash lookup can find a potential backmerge.
> */
> __rq = elv_rqhash_find(q, bio->bi_sector);
> if (__rq && elv_rq_merge_ok(__rq, bio)) {
> *req = __rq;
> return ELEVATOR_BACK_MERGE;
> }
> #endif
It's a given that not merging will provide better latency. We can't
disable that or performance will suffer A LOT on some systems. There are
ways to make it better, though. One would be to make the max request
size smaller, but that would also hurt for streamed workloads. Can you
try whether the below patch makes a difference? It will basically
disallow merges to a request that isn't the last one.
We should probably make the merging logic a bit more clever, since the
below wont work well for two (or more) streamed cases. I'll think a bit
about that.
Note this is totally untested!
diff --git a/block/elevator.c b/block/elevator.c
index 1975b61..d00a72b 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -497,9 +497,17 @@ int elv_merge(struct request_queue *q, struct request **req, struct bio *bio)
* See if our hash lookup can find a potential backmerge.
*/
__rq = elv_rqhash_find(q, bio->bi_sector);
- if (__rq && elv_rq_merge_ok(__rq, bio)) {
- *req = __rq;
- return ELEVATOR_BACK_MERGE;
+ if (__rq) {
+ /*
+ * If requests are queued behind this one, disallow merge. This
+ * prevents streaming IO from continually passing new IO.
+ */
+ if (elv_latter_request(q, __rq))
+ return ELEVATOR_NO_MERGE;
+ if (elv_rq_merge_ok(__rq, bio)) {
+ *req = __rq;
+ return ELEVATOR_BACK_MERGE;
+ }
}
if (e->ops->elevator_merge_fn)
--
Jens Axboe
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
