Patch name: dm-snapshot-remove-redundant-valid-test.patch
There is another valid test when we take the lock, the previous test can
be dropped.
Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx>
Reviewed-by: Jonathan Brassow <jbrassow@xxxxxxxxxx>
Reviewed-by: Mike Snitzer <snitzer@xxxxxxxxxx>
Index: linux-2.6/drivers/md/dm-snap.c
===================================================================
--- linux-2.6.orig/drivers/md/dm-snap.c
+++ linux-2.6/drivers/md/dm-snap.c
@@ -1043,15 +1043,11 @@ static int snapshot_map(struct dm_target
chunk = sector_to_chunk(s->store, bio->bi_sector);
- /* Full snapshots are not usable */
- /* To get here the table must be live so s->active is always set. */
- if (!s->valid)
- return -EIO;
-
/* FIXME: should only take write lock if we need
* to copy an exception */
down_write(&s->lock);
+ /* Full snapshots are not usable */
if (!s->valid) {
r = -EIO;
goto out_unlock;
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
