Balbir Singh wrote: > 2009/9/2 KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>: >> Ryo Tsuruta wrote: >>> Hi Kamezawa-san, >>> >>> As you wrote before (http://lkml.org/lkml/2009/7/22/65) >>>> To be honest, what I expected in these days for people of blockio >>>> cgroup is like following for getting room for themselves. >>> <<snip>> >>>> --- mmotm-2.6.31-Jul16.orig/include/linux/page_cgroup.h >>>> +++ mmotm-2.6.31-Jul16/include/linux/page_cgroup.h >>>> @@ -13,7 +13,7 @@ >>>>  struct page_cgroup { >>>>       unsigned long flags; >>>>       struct mem_cgroup *mem_cgroup; >>>> -     struct page *page; >>>> +     /* block io tracking will use extra unsigned long bytes */ >>>>       struct list_head lru;       /* per cgroup LRU list */ >>>> }; >>> >>> Have you already added a room for blkio_cgroup in struct page_cgroup? >> No. >> > > The diff above is unclear, are you removing struct page from page_cgroup? > I said him "if you want a room, plz get by youself, consider more" And offered this change. http://lkml.org/lkml/2009/7/22/65 you were CC'd. Because page_cgroup's layout is same to memmap, we can use similar function as page_cgroup_to_pfn(), pfn_to_page_cgroup(). And, we don't access page_cgroup->page in fast path. (maybe) But as I wrote, we're busy. I'll not do this until all performance fixes go ahead. Thanks, -Kame -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
