On Sun, 23 Aug 2009 02:11:07 -0400 Mike Snitzer <snitzer@xxxxxxxxxx> wrote: > This patch implements .iterate_devices for the origin and snapshot > targets. dm-snapshot's lack of .iterate_devices resulted in the > inability to properly establish queue_limits for both targets. > > With 4K sector drives: an unfortunate side-effect of not establishing > proper limits in either targets' DM device was that IO to the devices > would fail even though both had been created without error. Does this make the patch a regression fix? > Commit af4874e03ed82f050d5872d8c39ce64bf16b5c38 should have implemented > .iterate_devices for dm-snap.c's origin and snapshot targets. Please use the form af4874e03ed82f050d5872d8c39ce64bf16b5c38 ("dm target:s introduce iterate devices fn") when referring to commits. Because commits might have different IDs in different trees (I think that's the reason). -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel