Hi Andrea, From: Andrea Righi <righi.andrea@xxxxxxxxx> Subject: Re: [PATCH 4/7] blkio-cgroup: The body of blkio-cgroup Date: Mon, 4 May 2009 14:05:45 +0200 > On Tue, Apr 28, 2009 at 09:46:04PM +0900, Ryo Tsuruta wrote: > > The body of bio-cgroup. > > > > Based on 2.6.30-rc3-git3 > > Signed-off-by: Hirokazu Takahashi <taka@xxxxxxxxxxxxx> > > Signed-off-by: Ryo Tsuruta <ryov@xxxxxxxxxxxxx> > > Hi Ryo, > > few minor coding style issues reported by checkpatch.pl: Thanks for reporting these issues. I'll fix them in the next release. > > WARNING: line over 80 characters > #138: FILE: include/linux/biotrack.h:67: > +static inline void blkio_cgroup_set_owner(struct page *page, struct mm_struct *mm) > > WARNING: line over 80 characters > #152: FILE: include/linux/biotrack.h:81: > +static inline void blkio_cgroup_copy_owner(struct page *page, struct page *opage) > > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable > #513: FILE: mm/biotrack.c:265: > +EXPORT_SYMBOL(get_blkio_cgroup_id); > > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable > #514: FILE: mm/biotrack.c:266: > +EXPORT_SYMBOL(blkio_cgroup_lookup); > > total: 0 errors, 4 warnings, 515 lines checked > > -Andrea Thanks, Ryo Tsuruta -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
