On Mon, Feb 23, 2009 at 02:21:41PM -0500, Mikulas Patocka wrote: > Move wait queue declaration and unplug to dm_wait_for_completion. > The patch reorders functions a little bit. It doesn't change any > functionality. For proper non-deadlock operation, it is required > hat add_wait_queue happens before set_current_state(interruptible) > and before the test for !atomic_read(&md->pending) --- and this > patch follows that. Can you check md->wait is sufficiently protected and the reordering in this patch doesn't increase the likelihood of a race with its contents changing outside a lock? Alasdair -- agk@xxxxxxxxxx -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
