OK, an easy thing first. Please review all the debugging messages and decide whether they will really still be necessary in an upstream kernel. Then convert them to DM_DEBUG or DM_DEBUG_LIMIT as appropriate and remove the 'debug' option. If you genuinely believe you need to be able to enable some of these at runtime on a live machine - and so far no other part of dm has found that necessary - then you should offer some justification and extend the DM_DEBUG* macros (in a separate patch) to support that. If however this is more about statistics/verbosity - i.e. information the user might want to see about how the target is behaving, then consider alternative ways of making that information available to userspace. Alasdair -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
