On Wed, 29 Oct 2008 23:52:34 +0000
Alasdair G Kergon <agk@xxxxxxxxxx> wrote:
> On Mon, Oct 27, 2008 at 09:07:49PM +0900, FUJITA Tomonori wrote:
> > +struct dm_snap_exception *lookup_complete_exception(struct dm_snapshot *s,
> > + chunk_t chunk)
> > +{
> > + if (s->store.lookup_completed_exception)
> > + return s->store.lookup_completed_exception(&s->store, chunk);
> > + else
> > + return lookup_exception(&s->complete, chunk);
> > +}
>
> Can we have symmetry here such that lookup_completed_exception is *required* to be
> defined for all snapshot types?
Sure, we can. It would be cleaner, I guess. I'll do next time.
Thanks,
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
