Hi, > > > One additional issue with my scheme I just noticed is that I am putting > > > bio-cgroup in rb-tree. If there are stacked devices then bio/requests from > > > same cgroup can be at multiple levels of processing at same time. That > > > would mean that a single cgroup needs to be in multiple rb-trees at the > > > same time in various layers. So I might have to create a temporary object > > > which can associate with cgroup and get rid of that object once I don't > > > have the requests any more... > > > > You mean each layer should have its rb-tree? Is it per device? > > One lvm logical volume may probably consist from several physical > > volumes, which will be shared with other logical volumes. > > And some layers may split one bio into several bios. > > I hardly can imagine how these structures will be. > > > > Yes, one rb-tree per device, be it physical device or logical device > (because there is one request queue associated per physical/logical block > device). No, logical block devices doesn't have any request queues and they essentially won't block any bios unless it is impossible to handle them at the moment. Device-mappers never touch any request queues. > I was thinking of getting hold/hijack the bios as soon as they are > submitted to the device using associated request function. So if there > is a logical device built on top of two physical device, the associated > bio copy or other logic should not even see the bio the moment it is > submitted to the deivce. It will see the bio only when it is released > from associated rb-tree to them. Do you think this will not work? To me > this is what dm-ioband is doing logically. The only difference is that it > does this with the help of a separate request queue. I think it's easy to just make all logical device --- device mapper device --- and all physical device have their own bandwidth control mechanism. But I'm not clear how your algorithm works to control the bandwidth. At which level are you going to guarantee the bandwidth, at the logical volumes layer such as lvm or at the physical device layer? Thanks, Hirokazu Takahashi. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
