On Mon, 30 Jun 2008 08:13:07 +0900 "Takashi Sato" <t-sato@xxxxxxxxxxxxx> wrote: > > It's much better to use NULL here rather than literal zero because the > > reader of this code can then say "ah-hah, we're passing in a pointer". > > Whereas plain old "0" could be a pointer or a scalar. > > The second argument's type of freeze_bdev() is "long", not pointer as below. > struct super_block *freeze_bdev(struct block_device *, long timeout_msec); oh, ok, I goofed, sorry. > So "0" is reasonable, isn't it? yup. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
