Ah, ok. Thanks Mike I'll run that and repost. (Sorry for the error). Brian Wood Software Engineer Intel Corp., Manageability & Platform Software Division brian.j.wood@xxxxxxxxx >-----Original Message----- >From: dm-devel-bounces@xxxxxxxxxx [mailto:dm-devel-bounces@xxxxxxxxxx] On >Behalf Of Mike Anderson >Sent: Wednesday, December 05, 2007 9:57 AM >To: device-mapper development >Cc: Alasdair G Kergon >Subject: Re: [PATCH 1/2] add stripe end_io function and >eventtrigger > >Wood, Brian J <brian.j.wood@xxxxxxxxx> wrote: >> +static void trigger_event(struct work_struct *work) >> +{ >> + int i, len; >> + char dev_path[DEV_STR_LEN]; >> + struct stripe_c *sc = container_of(work, struct stripe_c, >> kstriped_ws); > >It appears your mailer is breaking lines which leads to hand edits prior >to trying to apply the patch. > >Your patch also appears to be adding extra whitespace. You want to run >checkpatch.pl prior to sending the patch out and correct all issues >listed. > >> + /* Finally as a last check, see if the inode mode is set >> >> + * to be a block device, record error if not */ > >> + if (!S_ISBLK(inode->i_mode)) { >> + atomic_inc(&(sc->stripe[i].error_count)); >> + } > >Code comment style and extra bracing. > >http://sources.redhat.com/lvm2/wiki/KernelPatchGuidelines > > >-andmike >-- >Michael Anderson >andmike@xxxxxxxxxxxxxxxxxx > >-- >dm-devel mailing list >dm-devel@xxxxxxxxxx >https://www.redhat.com/mailman/listinfo/dm-devel -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
