Hi Stefan, On Thu, 15 Nov 2007 16:07:35 +0100, "Stefan Bader" <Stefan.Bader@xxxxxxxxxx> wrote: > > > > Before discussing details, I would like to make my standpoint clear. > > > > - Minimize the number of sections user has to modify as possible > > > > - Don't confuse users by pretending too much flexibility > > > > > > > > If we could do with only one section, it would be ideal. > > > > However, wwid can be obtained only by getuid callout, which has > > > > side effects of accessing devices and yielding unpleasant kernel > > > > warning messages, etc. > > > > So the filtering has to be splitted into 2 stages at least: > > > > before running getuid callout and after that > > > > and we can't use wwid in the 1st stage. > > > > Not to pretend that mixing wwid filtering and others is possible, > > > > it's natural to have 2 different filtering sections. > > > > > > > > > The behavior that is not that well expected is that if you can not do > > > the following: > > > > > > blacklist { > > > devnode ".*" > > > wwid ".*" > > > } > > > blacklist_execptions { > > > devnode "^sda[0-9+]" > > > wwid "foo" > > > } > > > > Sorry, I don't understand what you mean. Could you elaborate that? > > Do you mean that my proposal doesn't work for the case above? > > Or do you mean that current code doesn't work as expected although > > we can specify like above, but my proposal removes the confusion? > > > I am sorry, I was a bit unclear. The example was for the current code, which > allows to write a blacklist like in the example but does not give the > expected result. Your proposal would (in my opinion) remove the confusion > because both stages would apply the rules in the order they are written. > Which is not the case in the current code. > > In the current code there are, from my point of view, two problems: > 1. the rules are not checked in the order they are written but in the order > devnode, wwid, device. > 2. the first match in the order above is used. There is no way to change > this. For example (current code): > > blacklist { > devnode ".*" > } > blacklist_exception { > wwid "foo" > devnode "dasda" > } > > This will only use dasda. The wwid entries are just useless. Thank you for the detailed explanation. I understand that you agree with my proposal. Thanks, Kiyoshi Ueda -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel