From: Dmitry Monakhov <dmonakhov@xxxxxxxxxx> Add a missing 'dm_put_device' in an error path in crypt target constructor. Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx> Signed-off-by: Milan Broz <mbroz@xxxxxxxxxx> Signed-off-by: Alasdair G Kergon <agk@xxxxxxxxxx> --- drivers/md/dm-crypt.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletion(-) Index: linux-2.6.23/drivers/md/dm-crypt.c =================================================================== --- linux-2.6.23.orig/drivers/md/dm-crypt.c 2007-10-12 13:15:20.000000000 +0100 +++ linux-2.6.23/drivers/md/dm-crypt.c 2007-10-12 13:15:30.000000000 +0100 @@ -882,7 +882,7 @@ static int crypt_ctr(struct dm_target *t cc->iv_mode = kmalloc(strlen(ivmode) + 1, GFP_KERNEL); if (!cc->iv_mode) { ti->error = "Error kmallocing iv_mode string"; - goto bad5; + goto bad_iv_mode; } strcpy(cc->iv_mode, ivmode); } else @@ -891,6 +891,8 @@ static int crypt_ctr(struct dm_target *t ti->private = cc; return 0; +bad_iv_mode: + dm_put_device(ti, cc->dev); bad5: bioset_free(cc->bs); bad_bs: -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel