On Mon, 2007-07-30 at 22:35 -0500, Mike Christie wrote:
> Chandra Seetharaman wrote:
> > On Mon, 2007-07-30 at 16:08 -0500, Mike Christie wrote:
> >> Chandra Seetharaman wrote:
> >>> Hi Dave,
> >>>
> >>> some coding style related comments (below).
> >>>
> >>
> >>>> + if (!error) {
> >>>> + err_flags = 0;
> >>>> + DMDEBUG("%s path activation command - success",
> >>>> + path->dev->name);
> >>> Mixed use of space and tab for indentation (many other places too).
> >>>
> >> Where is that rule for this type of plcae?
> >
> > Documentation/CodingStyle:
> > "Outside of comments, documentation and except in Kconfig, spaces are
> > never used for indentation, and the above example is deliberately
> > broken."
>
> Ah I see. I still think it is ok for this type of case though. Well, the
I see what you mean and agree with you.
> above chunk of code should actually be tabbed because it lines up
> perfectly (I think there are 8 spaces in the above snippet), but some of
> the other places are not. checkpatch.pl did not care about the others
> and it looks like reviewers like Andrew Morton did not care about some
> of the wierder spacing used in dm-mpath-rdac which did not fit the
> coding style doc or the existing code :)
I will check it out
>
> If we are getting all picky about that coding style I guess Dave should
No, I am not getting all picky :). Was trying to help to avoid some
churn when sent to mainline.
> run scripts/checkpatch.pl over his patches, because I think there are
> some other issues.
>
--
----------------------------------------------------------------------
Chandra Seetharaman | Be careful what you choose....
- sekharan@xxxxxxxxxx | .......you may get it.
----------------------------------------------------------------------
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
