add header! brassow There are now two phases to a suspend in device-mapper - presuspend and postsuspend. This patch removes the single 'suspend' in the logging API and replaces it with 'presuspend' and 'postsuspend' functions to better align it with the current DM implementation. Signed-off-by: Jonathan Brassow <jbrassow@xxxxxxxxxx> Index: linux-2.6.22-rc4-mm2/drivers/md/dm-log.c =================================================================== --- linux-2.6.22-rc4-mm2.orig/drivers/md/dm-log.c +++ linux-2.6.22-rc4-mm2/drivers/md/dm-log.c @@ -696,7 +696,7 @@ static struct dirty_log_type _disk_type .module = THIS_MODULE, .ctr = disk_ctr, .dtr = disk_dtr, - .suspend = disk_flush, + .postsuspend = disk_flush, .resume = disk_resume, .get_region_size = core_get_region_size, .is_clean = core_is_clean, Index: linux-2.6.22-rc4-mm2/drivers/md/dm-log.h =================================================================== --- linux-2.6.22-rc4-mm2.orig/drivers/md/dm-log.h +++ linux-2.6.22-rc4-mm2/drivers/md/dm-log.h @@ -32,7 +32,8 @@ struct dirty_log_type { * There are times when we don't want the log to touch * the disk. */ - int (*suspend)(struct dirty_log *log); + int (*presuspend)(struct dirty_log *log); + int (*postsuspend)(struct dirty_log *log); int (*resume)(struct dirty_log *log); /* Index: linux-2.6.22-rc4-mm2/drivers/md/dm-raid1.c =================================================================== --- linux-2.6.22-rc4-mm2.orig/drivers/md/dm-raid1.c +++ linux-2.6.22-rc4-mm2/drivers/md/dm-raid1.c @@ -1462,7 +1462,7 @@ static void mirror_postsuspend(struct dm wait_event(_kmirrord_recovery_stopped, !atomic_read(&ms->rh.recovery_in_flight)); - if (log->type->suspend && log->type->suspend(log)) + if (log->type->postsuspend && log->type->postsuspend(log)) /* FIXME: need better error handling */ DMWARN("log suspend failed"); } -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel