tiny patch: avoid an unnecessary test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Not a big deal (barely worth mentioning), but it might save
someone else a little time wondering "why".

2007-03-11  Jim Meyering  <jim@xxxxxxxxxxxx>

	Remove unnecessary test.
	* dmeventd/dmeventd.c (_alloc_dso_data): Don't test known-non-NULL
	memset return value.

2007-03-11  Jim Meyering  <jim@xxxxxxxxxxxx>
Index: dmeventd/dmeventd.c
===================================================================
RCS file: /cvs/dm/device-mapper/dmeventd/dmeventd.c,v
retrieving revision 1.46
diff -u -p -r1.46 dmeventd.c
--- dmeventd/dmeventd.c	2 Feb 2007 17:08:51 -0000	1.46
+++ dmeventd/dmeventd.c	12 Mar 2007 14:39:35 -0000
@@ -258,8 +258,8 @@ static struct dso_data *_alloc_dso_data(
 	if (!ret)
 		return NULL;

-	if (!memset(ret, 0, sizeof(*ret)) ||
-	    !(ret->dso_name = dm_strdup(data->dso_name))) {
+	memset(ret, 0, sizeof(*ret));
+	if (!(ret->dso_name = dm_strdup(data->dso_name))) {
 		dm_free(ret);
 		return NULL;
 	}

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux