On Thu, 2007-02-22 at 19:18 -0500, Daniel Drake wrote:
> Piet Delaney wrote:
> > On Sat, 2007-02-10 at 01:01 +0000, Daniel Drake wrote:
> >
> > Nice patch Daniel, wondering about using it in 2.6.12.
>
> It won't compile there. You can probably find a 2.6.12-compatible
> version in an EVMS tarball though.
I think I found it at:
http://dev.gentoo.org/~dsd/genpatches/patches-2.6.12-10.htm
looks like it should be in the extras patch I just downloaded:
4305_dm-bbr.patch
EVMS 2.5.2
Bad block relocation support for LiveCD users
What's the LiveCD got to do with it?
So if I install it I'd be want to be sure it works. How do ya test it?
>
> It's also not written by me, copyright messages indicate IBM wrote it.
>
> I will hopefully look at the last few feedback items and send in a newer
> version soon for the next round of feedback.
While break-pointing around the ext3 code looking for the cause of
a hang I was thinking that many times they leave in the white space
as if the brackets were there.
. .
. .
. .
if (panic) { if (panic)
printk("die\n"); printk("die\n");
}
return; return;
} }
Just leaving in the blank line seems to provide much of the
parse-ability of your current style to me and very likely
keeps it in the kernel coding style.
-piet
>
> Daniel
--
Piet Delaney Phone: (408) 200-5256
Blue Lane Technologies Fax: (408) 200-5299
10450 Bubb Rd.
Cupertino, Ca. 95014 Email: piet@xxxxxxxxxxxx
Attachment:
signature.asc
Description: This is a digitally signed message part
-- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
