On Mon, 30 Oct 2006, Alasdair G Kergon wrote: > > It cannot have been intentional as there was no mention of the change to the > userspace interface in the git changelog (and the interface version number > was not changed). > > A new patch is needed to revert the part of the patch that changed the > userspace interface. > > Please don't forget to copy in the appropriate maintainers when you send > messages like this one: > http://marc.theaimsgroup.com/?l=linux-netdev&m=115547174417490&w=2 > so they can provide acks:-) Yeah. Herbert, the breakage _seems_ to be due to the STATUSTYPE_TABLE case change: - cipher = crypto_tfm_alg_name(cc->tfm); + cipher = crypto_blkcipher_name(cc->tfm); which effectively changes "aes" into "cbc(aes)", which is wrong, since we show the chainmode separately. Please, somebody who knows this area, send me a fix, Linus ---- (maybe something like this trivial one? Totally untested, but it would seem to be the sane approach) diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c index a625576..645e3ce 100644 --- a/drivers/md/dm-crypt.c +++ b/drivers/md/dm-crypt.c @@ -925,8 +925,7 @@ static int crypt_status(struct dm_target break; case STATUSTYPE_TABLE: - cipher = crypto_blkcipher_name(cc->tfm); - + cipher = cc->cipher; chainmode = cc->chainmode; if (cc->iv_mode) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
