Hi, While reading the code I found a bug in the error path in alloc_dev in dm.c When blk_alloc_queue fails there is no call to free_minor. This patch fixes the problem. Signed-off-by: Ishai Rabinovitz <ishai@xxxxxxxxxxxxxx> Index: linux-2.6.18-devel/drivers/md/dm.c =================================================================== --- linux-2.6.18-devel.orig/drivers/md/dm.c +++ linux-2.6.18-devel/drivers/md/dm.c @@ -903,7 +903,7 @@ static struct mapped_device *alloc_dev(i md->queue = blk_alloc_queue(GFP_KERNEL); if (!md->queue) - goto bad1; + goto bad1_free_minor; md->queue->queuedata = md; md->queue->backing_dev_info.congested_fn = dm_any_congested; @@ -953,6 +953,7 @@ static struct mapped_device *alloc_dev(i mempool_destroy(md->io_pool); bad2: blk_cleanup_queue(md->queue); + bad1_free_minor: free_minor(minor); bad1: module_put(THIS_MODULE); -- Ishai Rabinovitz -- dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
