On Tue, May 09, 2006 at 10:00:18AM -0500, Jon Brassow wrote: > It looks reasonable at first glance, but I have to think about it more. > Do you have a test case that I can reproduce with? How about you create a device with an enormous zero mapping followed by a mirror mapping? > On May 8, 2006, at 11:55 PM, Neil Brown wrote: > > We will try to get this patch tested on the machine that showed the > > fault, but I would appreciate any feedback about the patch and I am > > still not very familiar with this code. It's not the first time we've found a bug like that:-( We need to review the rest of the file - on the face of it, more places look to be missing that adjustment. > >+ return (bio->bi_sector - rh->ms->ti->begin) >> rh->region_shift; Alasdair -- agk@xxxxxxxxxx -- dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel