The draft is good. This was/is a bug. Mit freundlichem Gruß, Stefan Bader SW Linux on zSeries Development & Services Stefan.Bader@xxxxxxxxxx ---------------------------------------------------------------------------------- When all other means of communication fail, try words. dm-devel-bounces@xxxxxxxxxx wrote on 04.05.2006 16:56:45: > On Tue, May 02, 2006 at 03:32:02PM -0700, Tom Kalus wrote: > > path_priority/pp_aula/spc.h > > > > Isn't the inquiry_data.product_identifier 16 bytes long? or do I need a > > later draft of SPC3... 21d - Feb 2005 > > Bug doesn't effect existing code, but it's still a bug. > > Rest looks ok, so far as I can tell. > > > > See attached patch. > > > > > > > diff --git a/path_priority/pp_alua/spc3.h b/path_priority/pp_alua/spc3.h > > index 11f5dbd..bddbbdd 100644 > > --- a/path_priority/pp_alua/spc3.h > > +++ b/path_priority/pp_alua/spc3.h > > @@ -148,10 +148,10 @@ struct inquiry_data { > > /* ......x. = command queue support */ > > /* .......x = vs2 */ > > unsigned char vendor_identification[8]; > > - unsigned char product_identification[8]; > > + unsigned char product_identification[16]; > > unsigned char product_revision[4]; > > unsigned char vendor_specific[20]; > > - unsigned char b48; /* xxxx.... = reserved */ > > + unsigned char b56; /* xxxx.... = reserved */ > > /* ....xx.. = clocking */ > > /* ......x. = qas */ > > /* .......x = ius */ > > Stefan, > > Can you you ack this one ? > > Regards, > cvaroqui > > -- > > dm-devel@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/dm-devel -- dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel