Hi Greg, Thank you for the comments. Greg KH wrote:
+static inline struct kobject *add_dir(struct kobject *parent, const char *name) +{ + struct kobject *k; + + if (!parent) + return NULL; + + k = kmalloc(sizeof(*k), GFP_KERNEL); + if (!k) + return NULL; + + memset(k, 0, sizeof(*k)); + k->parent = parent; + k->ktype = &dir_ktype; + kobject_set_name(k, name); + kobject_register(k); + + return k; +}This code looks good enough that we should add it to the core kobject code, don't you think? Also, you might use kzalloc instead of kmalloc here.
Yes, it would be nice if kobject core has this function. I'll move them to lib/kobject.c. -- Jun'ichi Nomura, NEC Solutions (America), Inc. -- dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
