On Tue, Nov 08, 2005 at 02:44:19PM +0100, Adrian Bunk wrote: > A function that is > - not used > - empty > - without a prototype in any header file > should be removed. I'd rather you submitted a patch to complete the function and invoke it in the appropriate place:-) But please don't remove comments indicating missing functionality: commenting it out till it's written would be better. Alasdair -- agk@xxxxxxxxxx > -/* > - * Cancels a kcopyd job, eg. someone might be deactivating a > - * mirror. > - */ > -int kcopyd_cancel(struct kcopyd_job *job, int block) > -{ > - /* FIXME: finish */ > - return -1; > -} -- dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel