On 2005-04-25T15:25:36, "goggin, edward" <egoggin@xxxxxxx> wrote: > Should reinstate_path() in dm-mpath.c only conditionally reset > current_pgpath if the restored path is in the same path priority group > as the current_pgpath instead of doing so unconditionally as is done > currently? > Albeit this change makes sense IFF it is architecturally > invalid to have a path selection policy which spans multiple path > priority groups -- as I think is currently the case. Agreed. I think the setting of current_pgpath = NULL; dates back to the times where we always switched to the highest priority group if it had any available paths. While it doesn't have any bad side effects (beyond invoking the __choose_pgpath()), it's a cleanup and optimization to remove that line. Sincerely, Lars Marowsky-Brée <lmb@xxxxxxx> -- High Availability & Clustering SUSE Labs, Research and Development SUSE LINUX Products GmbH - A Novell Business