On Thu, Jun 10, 2004 at 05:30:31PM +0000, Kevin Corry wrote: > And while we're in there hacking up that routine, we should probably add > proper error handling instead of just using BUG_ON() in the event someone > tries to read from multiple regions. At present, the num_regions parameter is not allowed to exceed 1 when reading. If it does, that should show up clearly as a coding error. Prefer WARN_ON() ? Alasdair -- agk@xxxxxxxxxx