Yup, you're right. I guess that explains why the async_io() routine doesn't have the same BUG() calls. All the raid1 calls are to async_io(). I'll put some thought into NOT using the bio_vec array to store the region number. So if the multi-region code works for async_io(), is there any reason we shouldn't just remove the BUG() calls from sync_io(), to keep the interfaces symmetric? On Thu, Jun 10, 2004 at 08:49:46PM -0500, Kevin Corry wrote: > On Thursday 10 June 2004 18:28, Dave Olien wrote: > > Sorry, I've been in a meeting for the last hour... > > > > I agree on both your counts. > > > > I've been wondering about the multiple region stuff. I don't > > think these routines are ever used to do multiple region IO. > > dm-mirror can definitely do multi-region copies. See dm-raid1.c::recover(). > > -- > Kevin Corry > kevcorry@xxxxxxxxxx > http://evms.sourceforge.net > > -- > > dm-devel@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/dm-devel