On Tue, Jan 20, 2004 at 04:53:11PM +0100, Christophe Saout wrote: > I think we should add additional checks to ensure that we don't run > into trouble with devices that have a non-512-byte sector size. You're correct that this is indeed needed. However your solution makes some assumptions about how the target is going to use the device. eg. you do the wrong thing for snapshot exception stores, or mirror logs. I think the correct solution would be to add some utility functions to dm-table.c in order to make it easy for the targets constructors themselves to do the checking. - Joe
