On Friday 06 June 2003 19:17, Greg KH wrote: > On Thu, Jun 05, 2003 at 10:39:43AM +0100, Joe Thornber wrote: > > Here's the header file for the the proposed new ioctl interface for > > dm. We've tried to change as little as possible to minimise code > > changes in LVM2 and EVMS. > > Minor comment: > - please do not use uint_32t types in kernel header files. Use > the proper __u32 type which is guarenteed to be the proper > size across the user/kernel boundry. I'm not sure what we were both smoking, but obviously all flavors of u32 should be the same size regardless of where they are located. As I understand it, the only interesting difference between __u32 and u32 is that the former is standard C while the latter is Linux's (sensible) local dialect. Regards, Daniel
