On Tuesday 25 February 2003 08:52, Joe Thornber wrote: > http://people.sistina.com/~thornber/patches/2.4-stable/2.4.20/2.4.20-dm-9.t >ar.bz2 > > Changes since 2.4.20-dm-8 > ------------------------- Looks like the fix for Revision 42 got misplaced. Here is that patch again. (This should also apply to 2.5.60-dm-1, Revision 5). Return correct error codes from dm_table_add_target(). --- linux-2.4.20a/drivers/md/dm-table.c 2003/02/13 16:18:01 +++ linux-2.4.20b/drivers/md/dm-table.c 2003/02/13 16:33:46 @@ -523,7 +523,7 @@ tgt->type = dm_get_target_type(type); if (!tgt->type) { tgt->error = "unknown target type"; - return r; + return -EINVAL; } tgt->table = t; @@ -536,6 +536,7 @@ */ if (!adjoin(t, tgt)) { tgt->error = "Gap in table"; + r = -EINVAL; goto bad; }