> > On Fri, Dec 27, 2002 at 04:55:31PM -0500, Kevin Corry wrote: > > Check memory allocations when cloning bio's. > > Rejected, clone_bio() cannot fail since it's allocating from a mempool > with __GFP_WAIT set. > > - Joe Hmm. Yep. I must have mistaken GFP_NOIO for GFP_ATOMIC. But based on that reasoning, shouldn't the bio_alloc() call in split_bvec() always return a valid bio, and hence make the checks in split_bvec() and __clone_and_map() unnecessary? Kevin
