Hi Milan, On Thu, Oct 28, 2021 at 09:14:10AM +0200, Milan Broz wrote: > Support for all formats is mandatory (the pain to support various kernel configuration is already enough), > so sorry, but I will not accept this patch. I can relate but in this case the default is enabled so unless someone really cares nothing changes. > Also you cannot disable commands on CLI this way, it breaks user interface. > (Command can fail, but must not dissappear.) Sounds doable, assuming the above is not a final NACK. ;) > What issues this solves have here? Why you cannot link it? On an embedded device with uClibc I need libiconv which is 1.4MB in size. I was hoping to avoid having to ship this rather large library. While it's awesome that cryptsetup now supports bitlk partitions, I don't think it will see much use on embedded devices (e.g. a small file server). > We use only some specific functions so the solution can be just to implement this internally. Converting passphrases to utf16 is mandatory for bitlk support, right? In general, I'm not sure if all this is feasible - libcryptsetup is already 1.9MB and maintaining a mini-iconv is error-prone and likely to remain mostly untested. Cheers, Phil _______________________________________________ dm-crypt mailing list -- dm-crypt@xxxxxxxx To unsubscribe send an email to dm-crypt-leave@xxxxxxxx
