Re: [PATCH] dm crypt: Avoid percpu_counter spinlock contention in crypt_page_alloc()

[Arne Welzel <arne.welzel@xxxxxxxxxxxxx>]

Mikulas,

On Tue, 10 Aug 2021, Mikulas Patocka wrote:

> Reviewed-by: Mikulas Patocka <mpatocka@xxxxxxxxxx>
>

thank you for the review. After looking at the submitted patch again,
seems more proper to use >= as the condition:

> > + if (unlikely(percpu_counter_read_positive(&cc->n_allocated_pages) > dm_crypt_pages_per_client) &&
                                                                        ^^
                                                                        >=
Would it be okay if I resend the patch with this changed and add your
Reviewed-by still? Would also fix some wording in the description and
dedent the perf report output somewhat.

Thanks,
   Arne

_______________________________________________
dm-crypt mailing list -- dm-crypt@xxxxxxxx
To unsubscribe send an email to dm-crypt-leave@xxxxxxxx