Re: Test suite is now FS-dependent (Re: cryptsetup 2.0.4)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/05/2018 10:18 AM, Milan Broz wrote:

On 04/08/18 22:40, Guilhem Moulin wrote:
Hi,

FWIW, ‘tests/blockwise-compat’ doesn't work consistently on all file
systems.  With

     BSIZE=$(stat -c "%o" $LOCAL_FILE)  ## 4096

`./unit-utils-io $LOCAL_FILE read_buffer $((BSIZE-1))` fails with ext4
(on read()) and tmpfs (on open(O_DIRECT)), but succeeds with btrfs (and
possibly other file systems).  The test-suite doesn't pass if that test
succeeds.

We'll add some less pedantic mode for tests related to misaligned direct I/O on filesystems.


Ah, btrfs. Until now it was nfs nuances that breaks everything :-)

(Direct-io should not be able to read buffer not aligned to block/page boundary,
but btrfs has apparently disagrees.)

Not only misaligned read. It passes even for misaligned direct write! I'm getting old for this... :)

Anyway, thank you for the report!
O.
_______________________________________________
dm-crypt mailing list
dm-crypt@xxxxxxxx
https://www.saout.de/mailman/listinfo/dm-crypt




[Index of Archives]     [Device Mapper Devel]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]     [Fedora Docs]

  Powered by Linux