Re: [PATCH] Speed up keyfile reading

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 08/15/2017 09:52 AM, Milan Broz wrote:
On 08/12/2017 08:26 PM, angelomariafederichini191269 wrote:
> Attached you find a patch which enhances the loop to use bulk read
> operations instead of single byte ones.

I added slightly modified version to the master branch
(there was a code shuffle so the function is moved to libcryptsetup internally).

Anyway, I added handling of -EINTR for read() and code will retry instead
of failing in this case - we have already wrapper read_buffer for that.

I will probably backport this later for stable 1.7.6.

Sounds good.

Thanks,

Thank you for your responsiveness and accepting the patch. Also thanks to Michael and Arno for the quick responses and enlightening comments about entropy in keyfiles.

Best
Angelo
_______________________________________________
dm-crypt mailing list
dm-crypt@xxxxxxxx
http://www.saout.de/mailman/listinfo/dm-crypt

[Index of Archives]     [Device Mapper Devel]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]     [Fedora Docs]

  Powered by Linux