At Tue, 09 Sep 2008 19:53:07 +0200, Milan Broz <mbroz@xxxxxxxxxx> wrote: > > Clemens Fruhwirth wrote: > > I remember that this symbol isn't exported in all versions of > > libdevmapper, that's why it's still the reinitialization trick. (Last > > time I checked reinitialization didn't cause much harm). > > well, it was introduced in DM source tree in December 2005. cryptsetup-luks is older than that :) But I guess it safe to assume that all distros bumped the version of libdevmapper. So let's just keep the correct API call. > > I'm trying to get rid of the all-in-one, nobody-actually-knows-what-parts-are-used > > crypt_option structure. > > > > Is there a reason for you to reintroduce it? > > I need name (already there) and device size at least. > Otherwise it must run one ioctl more to check for device size > (for replacing with error segment). > But we have alresy this size in options, just need to pass it through. > > Anyway, in previous code was structure crypt_option uninitialized > in remove_mapping() (with random data in it, except device name), > now is it zeroed and filled through setup_mapping. Yes, zeroing should be done. Also I should start to rewrite the backends to get rid of the options struct. However, in the mean time could you just remove the use of crypt_option except before that actual backend call? Then, the patch is ready to merge (at least from my perspective) Thanks! Btw: Do you have a Google Code account? -- Fruhwirth Clemens - http://clemens.endorphin.org --------------------------------------------------------------------- dm-crypt mailing list - http://www.saout.de/misc/dm-crypt/ To unsubscribe, e-mail: dm-crypt-unsubscribe@xxxxxxxx For additional commands, e-mail: dm-crypt-help@xxxxxxxx
