> > + device_type = "pci"; > > + interrupt-parent = <&gic>; > > + interrupts = < 0 118 4 > > + 0 116 4 > > + 0 115 4 // MSI_1 [63...32] > > + 0 114 4 >; // MSI_0 [31...0] > > Better write these as tuples: > > interrupts = <0 118 4>, <0 116 4>, <0 115 4>, <0 114 4>; > > And maybe reverse the order? It looks that might be what the soc > integration person had in mind. > > Also, what is interrupt <0 117 4>? Is that connected here as well? > Better list it as well then, even if you don't use it. > We have it but not using it, we will list it. > > + interrupt-map-mask = <0x0 0x0 0x0 0x7>; > > + interrupt-map = <0x0 0x0 0x0 0x1 &pcie_intc 0x1 > > + 0x0 0x0 0x0 0x2 &pcie_intc 0x2 > > + 0x0 0x0 0x0 0x3 &pcie_intc 0x3 > > + 0x0 0x0 0x0 0x4 &pcie_intc 0x4>; > > > + msi-parent = <&nwl_pcie>; > > + reg = <0x0 0xfd0e0000 0x1000 > > + 0x0 0xfd480000 0x1000 > > + 0x0 0xE0000000 0x1000000>; > > Same grouping for reg and interrupt-map as above for interrupts. Grouping reg and interrupt-map as tuples will make lengthy line and reduces readability, is it compulsory ? > > > + reg-names = "breg", "pcireg", "cfg"; > > + ranges = <0x02000000 0x00000000 0xE1000000 0x00000000 > > + 0xE1000000 0 0x0F000000>; > > No I/O space or prefetcheable memory? > > Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
