Re: [linux-nfc] [PATCH v2 4/9] NFC: nfcmrvl: allow low level drivers to configure head/tail room

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Samuel,

> Le 21 oct. 2015 à 08:00, Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> a écrit :
> 
> Hi Vincent,
> 
>> On Mon, Sep 28, 2015 at 02:33:09PM +0200, Vincent Cuissard wrote:
>> diff --git a/include/linux/platform_data/nfcmrvl.h b/include/linux/platform_data/nfcmrvl.h
>> index ac91707..6f6ba27 100644
>> --- a/include/linux/platform_data/nfcmrvl.h
>> +++ b/include/linux/platform_data/nfcmrvl.h
>> @@ -26,6 +26,9 @@ struct nfcmrvl_platform_data {
>>    unsigned int reset_n_io;
>>    /* Tell if transport is muxed in HCI one */
>>    unsigned int hci_muxed;
>> +    /* Tell generic driver that the PHY requires some headroom space */
>> +    unsigned int phy_headroom;
>> +    unsigned int phy_tailroom;
> This does not seems to be a platform data, but rather a static one that
> only depends on the selected PHY.
> It would make more sense to pass the selected PHY to
> nfcmrvl_nci_register_dev() and define the head and tail room depending
> on that.

Ok.

Br,
-- 
Vincent--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux