On Tue, Oct 20, 2015 at 7:09 PM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> On Fri, Oct 16, 2015 at 2:49 PM, Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx> wrote:
>> Add all R-Car H3 CPG Core Clock Outputs defined in the datasheet.
>
> Cfr. Table 8.2a ("List of Clocks [R-Car H3]").
Thanks for this additional information. Would it be possible to add
that table pointer together with data sheet revision to the commit
message or a comment in the code so we know which version of the
documentation this file is based on?
>> --- /dev/null
>> +++ b/include/dt-bindings/clock/r8a7795-cpg-mssr.h
>> @@ -0,0 +1,63 @@
>> +/*
>> + * Copyright (C) 2015 Renesas Electronics Corp.
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + */
>> +#ifndef __DT_BINDINGS_CLOCK_R8A7795_CPG_MSSR_H__
>> +#define __DT_BINDINGS_CLOCK_R8A7795_CPG_MSSR_H__
>> +
>> +#include <dt-bindings/clock/renesas-cpg-mssr.h>
>> +
>> +/* r8a7795 CPG Core Clocks */
>> +#define R8A7795_CLK_Z 0
>> +#define R8A7795_CLK_Z2 1
>> +#define R8A7795_CLK_ZR 2
>> +#define R8A7795_CLK_ZG 3
>> +#define R8A7795_CLK_ZTR 4
>> +#define R8A7795_CLK_ZTRD2 5
>> +#define R8A7795_CLK_ZT 6
>> +#define R8A7795_CLK_ZX 7
>> +#define R8A7795_CLK_S0D1 8
>> +#define R8A7795_CLK_S0D4 9
>> +#define R8A7795_CLK_S1D1 10
>> +#define R8A7795_CLK_S1D2 11
>> +#define R8A7795_CLK_S1D4 12
>> +#define R8A7795_CLK_S2D1 13
>> +#define R8A7795_CLK_S2D2 14
>> +#define R8A7795_CLK_S2D4 15
>> +#define R8A7795_CLK_S3D1 16
>> +#define R8A7795_CLK_S3D2 17
>> +#define R8A7795_CLK_S3D4 18
>
> Please note that I deliberately left out S[0-3], as they're used as
> internal clock
> sources only.
Omitting internal clock sources sounds sane to me. If you're going to
update the commit message they may I suggest that you list the
intentionally omitted clocks there?
Reviewed-by: Magnus Damm <damm+renesas@xxxxxxxxxxxxx>
Thanks for your help!
Best,
/ magnus
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
