Hi Geert, On Tue, Oct 20, 2015 at 9:16 PM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > On Fri, Oct 16, 2015 at 2:49 PM, Geert Uytterhoeven > <geert+renesas@xxxxxxxxx> wrote: >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt >> @@ -0,0 +1,71 @@ >> +* Renesas Clock Pulse Generator / Module Standby and Software Reset >> + >> +On Renesas ARM SoCs (SH/R-Mobile, R-Car, RZ), the CPG (Clock Pulse Generator) >> +and MSSR (Module Standby and Software Reset) blocks are intimately connected, >> +and share the same register block. >> + >> +They provide the following functionalities: >> + - The CPG block generates various core clocks, >> + - The MSSR block provides two functions: >> + 1. Module Standby, providing a Clock Domain to control the clock supply >> + to individual SoC devices, >> + 2. Reset Control, to perform a software reset of individual SoC devices. >> + >> +Required Properties: >> + - compatible: Must be one of: >> + - "renesas,r8a7791-cpg-mssr" for the r8a7791 SoC > > I'll drop the reference to "r8a7791", as we won't convert r8a7791 (yet). > >> + - "renesas,r8a7795-cpg-mssr" for the r8a7795 SoC >> + >> + - reg: Base address and length of the memory resource used by the CPG/MSSR >> + block >> + >> + - clocks: References to external parent clocks, one entry for each entry in >> + clock-names >> + - clock-names: List of external parent clock names. Valid names are: >> + - "extal" (r8a7791, r8a7795) >> + - "extalr" (r8a7795) >> + - "usb_extal" (r8a7791) > > Likewise. Yeah, dropping r8a7791 from the initial version of this DT binding seems like a good idea to me as well. All looks good to me. Thanks for preparing this nicely written DT binding document! Reviewed-by: Magnus Damm <damm+renesas@xxxxxxxxxxxxx> Cheers, / magnus -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
