> -----Original Message----- > From: Sudeep Holla [mailto:sudeep.holla@xxxxxxx] > Sent: 20 October 2015 14:36 > To: Anup Patel > Cc: David Woodhouse; Brian Norris; linux-mtd@xxxxxxxxxxxxxxxxxxx; Sudeep > Holla; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Catalin > Marinas; Will Deacon; Ray Jui; Scott Branden; Florian Fainelli; Pramod Kumar; > Vikram Prakash; Sandeep Tripathy; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; bcm-kernel- > feedback-list > Subject: Re: [PATCH v2 4/4] arm64: dts: Add BRCM IPROC NAND DT node for > NS2 > > > > On 16/10/15 10:08, Anup Patel wrote: > > The NAND controller on NS2 SoC is compatible with existing BRCM IPROC > > NAND driver so let's enable it in NS2 DT and > > NS2 SVK DT. > > > > Signed-off-by: Anup Patel <anup.patel@xxxxxxxxxxxx> > > Reviewed-by: Ray Jui <rjui@xxxxxxxxxxxx> > > Reviewed-by: Scott Branden <sbranden@xxxxxxxxxxxx> > > --- > > arch/arm64/boot/dts/broadcom/ns2-svk.dts | 12 ++++++++++++ > > arch/arm64/boot/dts/broadcom/ns2.dtsi | 14 ++++++++++++++ > > 2 files changed, 26 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/broadcom/ns2-svk.dts > > b/arch/arm64/boot/dts/broadcom/ns2-svk.dts > > index e5950d5..a754160 100644 > > --- a/arch/arm64/boot/dts/broadcom/ns2-svk.dts > > +++ b/arch/arm64/boot/dts/broadcom/ns2-svk.dts > > @@ -63,5 +63,17 @@ > > uart3: serial@66130000 { > > status = "ok"; > > }; > > Better to change even the above reference, see below. > > > + > > + nand: nand@66460000 { > > In most of the cases where such static overlays are done, I have seen the labels > being used to refer back the node. Using the complete node name again is kind > of inviting trouble as even minor typo results in creation of another node. Thanks for pointing. I will use label here for both uart3 and nand. Regards, Anup -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
