Re: [PATCH] iommu/ipmmu-vmsa: Include SoC part number in DT binding docs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Laurent,

On Mon, Oct 19, 2015 at 3:44 PM, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> Hi Magnus,
>
> Thank you for the patch.

Thanks for your feedback!

> On Monday 19 October 2015 12:10:03 Magnus Damm wrote:
>> From: Magnus Damm <damm+renesas@xxxxxxxxxxxxx>
>>
>> Add part numbers for APE6 and current set of R-Car Gen2 SoCs to the
>> IPMMU DT binding documentation. The example is also updated to show
>> how the generic compatible string may be used as fallback.
>
> I'd use a wording stronger than "may" here, as the generic compatible value is
> required. I would also explicitly state that in the bindings documentation.

I don't mind using a different wording, but it becomes a bit difficult
to describe exactly when to use the generic compatible string and when
not to. Is it always required, or does it depend on the hardware?

 "For compatible hardware please use the generic compat string."
Compatible with what? =)

Any ideas how to describe it correctly in the binding documentation?

Cheers,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux