On Fri, Oct 16, 2015 at 02:46:23PM +0800, Chen-Yu Tsai wrote: > On Fri, Oct 16, 2015 at 2:41 PM, Maxime Ripard > <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote: > > On Thu, Oct 15, 2015 at 12:32:19AM +0800, Chen-Yu Tsai wrote: > >> The AXP223 is a new PMIC commonly paired with Allwinner A23/A33 SoCs. > >> It is functionally identical to AXP221; only the regulator default > >> voltage/status and the external host interface are different. > >> > >> Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx> > >> --- > >> drivers/mfd/Kconfig | 12 ++++++ > >> drivers/mfd/Makefile | 1 + > >> drivers/mfd/axp20x-core.c | 2 + > >> drivers/mfd/axp20x-rsb.c | 93 ++++++++++++++++++++++++++++++++++++++++++++++ > >> include/linux/mfd/axp20x.h | 1 + > >> 5 files changed, 109 insertions(+) > >> create mode 100644 drivers/mfd/axp20x-rsb.c > >> > >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > >> index 9ba3feb3f2fc..6e5edb61d42e 100644 > >> --- a/drivers/mfd/Kconfig > >> +++ b/drivers/mfd/Kconfig > >> @@ -84,6 +84,7 @@ config MFD_BCM590XX > >> config MFD_AXP20X > >> bool "X-Powers AXP series PMICs" > >> select MFD_AXP20X_I2C > >> + select MFD_AXP20X_RSB > >> > >> config MFD_AXP20X_CORE > >> bool > >> @@ -102,6 +103,17 @@ config MFD_AXP20X_I2C > >> components like regulators or the PEK (Power Enable Key) under the > >> corresponding menus. > >> > >> +config MFD_AXP20X_RSB > >> + bool "X-Powers AXP series RSB PMICs" > >> + select MFD_AXP20X_CORE > >> + depends on SUNXI_RSB=y > > > > Do we need that? Even if the bus is compiled as a module, the driver > > will not be probed before that, will it? > > There's a compile/link dependency on the __devm_regmap_init_sunxi_rsb(). If it's exported, everything should be fine, no? > And both drivers are bool, i.e. can't be compiled as a module. What we > don't want is enabling MFD_AXP20X_RSB without SUNXI_RSB. What would really be the issue here? The driver wouldn't be probed, and that's it. Or am I missing something? Maxime > AFAIK the same goes for the I2C version. -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature
