Re: [PATCH 03/25] scsi: hisi_sas: add initial bare driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 






On 10/15/2015 05:23 PM, John Garry wrote:
On 15/10/2015 09:49, Xinwei Kong wrote:



+++ b/drivers/scsi/hisi_sas/hisi_sas.h
@@ -0,0 +1,24 @@
+/*
+ * Copyright (c) 2015 Linaro Ltd.
+ * Copyright (c) 2015 Hisilicon Limited.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.

+MODULE_VERSION(DRV_VERSION);
+MODULE_LICENSE("GPL");
V2
Can add. We do say in the header that it is v2.

No, should use MODULE_LICENSE("GPL");

include/linux/module.h

/*
 * The following license idents are currently accepted as indicating free
 * software modules
 *
 *      "GPL"                           [GNU Public License v2 or later]
 *      "GPL v2"                        [GNU Public License v2]

Thanks
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux