Re: [PATCH-RFC 6/7] drivers: of: ifdef out cmdline section

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 






There's one last little wrinkle .. In the current setup the defconfig CONFIG_CMDLINE="" is used as a default in case the device tree has nothing in it. In my changes, there is no identical functionality. The only similar thing I have is the the CONFIG_CMDLINE_APPEND="" . The main difference is that in the current implementation CONFIG_CMDLINE="" doesn't get added at all if there is a device tree bootargs, but with my implementation this line would be added unconditionally. It would represent a subtle change where people would have to add into the DT bootargs something to override what might be in the default command line.

For example,

if a config has CONFIG_CMDLINE_APPEND="debug" then they would have to add a "loglevel=7" into the DT bootargs to get back to normal. I wouldn't think people would want "debug" as the default, but oddly enough some of the configs do have this. Some of them also have default ip address setting, nfsroot= settings, and loglevel= settings.

What are your thoughts on this ? I think using the append type default makes more sense because it's actually setting up global defaults. The current complete replacement scheme seems to set the stage for people to make an entirely custom default for a single development machine, which IMO doesn't make sense. However, I'm not sure what the intent is with the current setup.

Daniel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux