On 13/10/2015 07:12, Hannes Reinecke wrote:
On 10/12/2015 05:20 PM, John Garry wrote:
This SAS ID is chosen as Huawei IEEE id: 001882
Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
---
drivers/scsi/hisi_sas/hisi_sas_init.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_init.c b/drivers/scsi/hisi_sas/hisi_sas_init.c
index 44fc524..c295c39 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_init.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_init.c
@@ -283,6 +283,19 @@ err_out:
return NULL;
}
+static void hisi_sas_init_add(struct hisi_hba *hisi_hba)
+{
+ u8 i;
+
+ /* Huawei IEEE id (001882) */
+ for (i = 0; i < hisi_hba->n_phy; i++)
+ hisi_hba->phy[i].dev_sas_addr =
+ cpu_to_be64(0x5001882016072015ULL);
+
Ouch. Each phy has the same SAS address?
For all boards? Ever?
Not sure if that's a good idea, nor even valid.
It'll confuse the hell out of any SAS array.
Please provide a means of having individual SAS addresses for each HBA.
Cheers,
Hannes
Hello,
Are you saying we should be getting the SAS address from fw with
sas_request_addr() or the like?
Marvell solution seems to hardcode it.
thanks,
John
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
