On Wed, 30 Sep 2015, Tomi Valkeinen wrote:
> Add DT binding for led-backlight.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> ---
> .../bindings/video/backlight/led-backlight.txt | 30 ++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/video/backlight/led-backlight.txt
>
> diff --git a/Documentation/devicetree/bindings/video/backlight/led-backlight.txt b/Documentation/devicetree/bindings/video/backlight/led-backlight.txt
> new file mode 100644
> index 000000000000..d4621d7414bc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/video/backlight/led-backlight.txt
> @@ -0,0 +1,30 @@
> +led-backlight bindings
Make this look like a heading, rather than just another binding.
I would expect to see "LED Backlight Bindings" or similar.
> +Required properties:
> + - compatible: "led-backlight"
> + - leds: phandle to a led OF node [0]
s/phandle/Phandle/
s/led/LED/
s/[0]/(See: ../leds/common.txt)
> + - brightness-levels: Array of distinct LED brightness levels. These
> + are in the range from 0 to 255, passed to the LED class driver.
> + - default-brightness-level: the default brightness level (index into the
s/the/The/
> + array defined by the "brightness-levels" property)
Tab this out, so:
- compatible : "led-backlight"
- leds : phandle to a led OF node [0]
- brightness-levels : Array of distinct LED brightness levels. These
are in the range from 0 to 255, passed to the LED class driver.
- default-brightness-level : the default brightness level (index into the
array defined by the "brightness-levels" property)
Etc.
> +Optional properties:
> + - power-supply: regulator for supply voltage
s/regulator/Regulator/
> + - enable-gpios: contains a single GPIO specifier for the GPIO which enables
s/contains/Contains/
> + and disables the backlight (see GPIO binding[1])
s/[1]/(See: ../gpio/gpio.txt)
> +[0]: Documentation/devicetree/bindings/leds/common.txt
> +[1]: Documentation/devicetree/bindings/gpio/gpio.txt
Remove these.
> +Example:
> +
> + backlight {
> + compatible = "led-backlight";
> + leds = <&backlight_led>;
> +
> + brightness-levels = <0 4 8 16 32 64 128 255>;
> + default-brightness-level = <6>;
> +
> + power-supply = <&vdd_bl_reg>;
> + enable-gpios = <&gpio 58 0>;
> + };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
