Re: [PATCH 14/25] scsi: hisi_sas: add ssp command function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi John,

[auto build test ERROR on scsi/for-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/John-Garry/HiSilicon-SAS-driver/20151012-231929
config: m68k-allmodconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All error/warnings (new ones prefixed by >>):

   drivers/scsi/hisi_sas/hisi_sas_main.c: In function 'hisi_sas_task_prep':
>> drivers/scsi/hisi_sas/hisi_sas_main.c:169:2: error: implicit declaration of function 'dma_pool_alloc' [-Werror=implicit-function-declaration]
     slot->status_buffer = dma_pool_alloc(hisi_hba->status_buffer_pool,
     ^
>> drivers/scsi/hisi_sas/hisi_sas_main.c:169:22: warning: assignment makes pointer from integer without a cast
     slot->status_buffer = dma_pool_alloc(hisi_hba->status_buffer_pool,
                         ^
   drivers/scsi/hisi_sas/hisi_sas_main.c:176:22: warning: assignment makes pointer from integer without a cast
     slot->command_table = dma_pool_alloc(hisi_hba->command_table_pool,
                         ^
>> drivers/scsi/hisi_sas/hisi_sas_main.c:226:2: error: implicit declaration of function 'dma_pool_free' [-Werror=implicit-function-declaration]
     dma_pool_free(hisi_hba->sge_page_pool, slot->sge_page,
     ^
   cc1: some warnings being treated as errors
--
   drivers/scsi/hisi_sas/hisi_sas_v1_hw.c: In function 'prep_prd_sge_v1_hw':
>> drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:822:2: error: implicit declaration of function 'dma_pool_alloc' [-Werror=implicit-function-declaration]
     slot->sge_page = dma_pool_alloc(hisi_hba->sge_page_pool, GFP_ATOMIC,
     ^
>> drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:822:17: warning: assignment makes pointer from integer without a cast
     slot->sge_page = dma_pool_alloc(hisi_hba->sge_page_pool, GFP_ATOMIC,
                    ^
   cc1: some warnings being treated as errors

vim +/dma_pool_alloc +169 drivers/scsi/hisi_sas/hisi_sas_main.c

   163		slot->n_elem = n_elem;
   164		slot->dlvry_queue = dlvry_queue;
   165		slot->dlvry_queue_slot = dlvry_queue_slot;
   166		cmd_hdr_base = hisi_hba->cmd_hdr[dlvry_queue];
   167		slot->cmd_hdr = &cmd_hdr_base[dlvry_queue_slot];
   168	
 > 169		slot->status_buffer = dma_pool_alloc(hisi_hba->status_buffer_pool,
   170						     GFP_ATOMIC,
   171						     &slot->status_buffer_dma);
   172		if (!slot->status_buffer)
   173			goto err_out_slot_buf;
   174		memset(slot->status_buffer, 0, HISI_SAS_STATUS_BUF_SZ);
   175	
   176		slot->command_table = dma_pool_alloc(hisi_hba->command_table_pool,
   177						     GFP_ATOMIC,
   178						     &slot->command_table_dma);
   179		if (!slot->command_table)
   180			goto err_out_status_buf;
   181		memset(slot->command_table, 0, HISI_SAS_COMMAND_TABLE_SZ);
   182		memset(slot->cmd_hdr, 0, sizeof(struct hisi_sas_cmd_hdr));
   183	
   184		tei.hdr = slot->cmd_hdr;
   185		tei.task = task;
   186		tei.n_elem = n_elem;
   187		tei.slot = slot;
   188		switch (task->task_proto) {
   189		case SAS_PROTOCOL_SSP:
   190			rc = hisi_sas_task_prep_ssp(hisi_hba, &tei, is_tmf, tmf);
   191			break;
   192		case SAS_PROTOCOL_SMP:
   193		case SAS_PROTOCOL_SATA:
   194		case SAS_PROTOCOL_STP:
   195		case SAS_PROTOCOL_SATA | SAS_PROTOCOL_STP:
   196		default:
   197			dev_err(dev, "task prep: unknown/unsupported proto (0x%x)\n",
   198				task->task_proto);
   199			rc = -EINVAL;
   200			break;
   201		}
   202	
   203		if (rc) {
   204			dev_err(dev, "task prep: rc = 0x%x\n", rc);
   205			if (slot->sge_page)
   206				goto err_out_sge;
   207			goto err_out_command_table;
   208		}
   209	
   210		slot->task = task;
   211		slot->port = tei.port;
   212		task->lldd_task = slot;
   213		list_add_tail(&slot->entry, &tei.port->list);
   214		spin_lock(&task->task_state_lock);
   215		task->task_state_flags |= SAS_TASK_AT_INITIATOR;
   216		spin_unlock(&task->task_state_lock);
   217	
   218		hisi_hba->slot_prep = slot;
   219	
   220		sas_dev->running_req++;
   221		++(*pass);
   222	
   223		return rc;
   224	
   225	err_out_sge:
 > 226		dma_pool_free(hisi_hba->sge_page_pool, slot->sge_page,
   227			slot->sge_page_dma);
   228	err_out_command_table:
   229		dma_pool_free(hisi_hba->command_table_pool, slot->command_table,

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux