Hey Rob, On Thu, 2015-10-08 at 11:50 -0500, Rob Herring wrote: > On Thu, Oct 8, 2015 at 8:31 AM, Sjoerd Simons > <sjoerd.simons@xxxxxxxxxxxxxxx> wrote: > > Add devicetree bindings for the spdif tranceiver found on > > found on rk3066, rk3188 and rk3288 SoCs > > > > Signed-off-by: Sjoerd Simons <sjoerd.simons@xxxxxxxxxxxxxxx> > > > > --- > > > > Changes in v4: > > - Require rockchip,grf on RK3288 as the 8 channel solution has to > > be > > selected on that SoC > > - Make the compatibility string one of a known list rather then > > requiring a precise list of options. > > - Change the clock names to hclk and mclk instead of spdif_hclk and > > spdif_mclk to better match the implementation and data sheets. > > > > Changes in v3: None > > Changes in v2: None > > > > .../devicetree/bindings/sound/rockchip-spdif.txt | 44 > > ++++++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/sound/rockchip-spdif.txt > > > > diff --git a/Documentation/devicetree/bindings/sound/rockchip > > -spdif.txt b/Documentation/devicetree/bindings/sound/rockchip > > -spdif.txt > > new file mode 100644 > > index 0000000..33dd82c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/rockchip-spdif.txt > > @@ -0,0 +1,44 @@ > > +* Rockchip SPDIF transceiver > > + > > +The S/PDIF audio block is a stereo transceiver that allows the > > +processor to receive and transmit digital audio via an coaxial > > cable or > > +a fibre cable. > > + > > +Required properties: > > + > > +- compatible: should be one of the following: > > + - "rockchip,rk3288-spdif", "rockchip,rk3188-spdif" or > > + "rockchip,rk3066-spdif" > > +- reg: physical base address of the controller and length of > > memory mapped > > + region. > > +- interrupts: should contain the SPDIF interrupt. > > > +- #address-cells: should be 1. > > +- #size-cells: should be 0. > > Why do you need these? Are you going to have sub nodes? Oh good spot, it looks like I indeed don't need this. (for reference, this came from the rockchip i2s' drivers device-tree documentation and i mindlessly left it in). Thanks!, -- Sjoerd Simons Collabora Ltd. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
