On Tue, Oct 6, 2015 at 9:32 PM, Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote:
> Rob Herring <robh@xxxxxxxxxx> writes:
>>> + "marvell,pxa2xx-lcdc",
>>
>> No differences in h/w for any of the chips?
> All pxa25x, pxa27x and pxa3xx are compatible.
> AFAIK, pxa3xx has an IP with additional registers. But :
> - these (this) register(s) is not necessary for the display controller to work
> (it's more a control to shift red/green/blue values, and energy management)
> - all the registers in pxa2{5,7}x are the same in pxa3xx
So the pxa3xx is pxa2xx compatible. The pxa3xx device tree should
contain compatible = "marvell,pxa3xx-lcdc", "marvell,pxa2xx-lcdc";
That way we can just ignore the pxa3xx compatible value until the need
arises to do something different with the additional registers, and if
that happens we already have it in the device trees.
>> If lcd-type is smart-panel, then this node would not make sense.
> Ah I see, so this could be optional maybe ?
>
> Actually when I'll move the panel definition to bindings/display/panel, is this
> what I should do :
> - create a file marvell,pxa2xx-panel
> - input all these properties into this file
>
> And then, when a board maintainer will create a devicetree description, he will
> write something like :
> compatible = "toshiba,ltm0305a776";
> compatible = "marvell,pxa2xx-panel";
> lcd-type = "color-tft";
> ...
>
> If that's the case, I wonder how to "enforce" that a panel used with
> marvell,pxa2xx-lcdc (through the of_graph 'port' node) be compatible with
> marvell,pxa2xx-panel ?
I think we should move to use drm simple-panel as soon as possible,
but until this information can be derived from the compatible string,
it should maybe stay contained to the lcdc node. At least I don't
think adding a marvell panel compatible is a solution. Maybe this
could be generalized and added as an optional property to the
simple-panel bindings.
regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
